This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(cody-gateway): Fix Google flagging configuration#63305
Merged
Conversation
abeatrix
approved these changes
Jun 17, 2024
abeatrix
left a comment
Contributor
There was a problem hiding this comment.
havent tested it with a local instance but the code change lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently noticed that 100% of all LLM requests routed to Google-provided LLMs were getting flagged, and for the same reasons ["high_max_tokens_to_sample","blocked_phrase"].
After FAR, FAR more head scratching than I care to admit to. I realized the problem: that we were never actually initializing the
Google.FlaggingConfigsettings. So when we were inspecting Gemini requests for potential abuse, we were comparing them against the zero-state forflaggingConfig. e.g. does this prompt have a higherMaxTokensToSamplethan 0?🤦 Super easy mistake to make. We now confirm that something is in the
flaggingConfigbefore assuming it is legitimate.Fixes https://github.com/sourcegraph/abuse-ban-bot/issues/32.
Test plan
CI/CD