This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(cody-gateway): Disable flagging Google requests#63295
Merged
Conversation
abeatrix
reviewed
Jun 17, 2024
chrsmith
approved these changes
Jun 17, 2024
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
Like @abeatrix mentioned, let's just not call the function at all and just return nil, nil like we do for Fireworks.
But merging this to get things unblocked sounds good. And then we'll figure out why requests to Gemini are getting flagged.
Contributor
|
David is signing off for the night. I'll ferry this PR into production. And see what could be the root cause here, since I'm inclined to think that the flagging logic is actually "correct". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR turns off flagging for all Google models entirely.
Test plan
Not tested yet.