This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Wraps up syntactic usages in resolvers#63285
Merged
Merged
Conversation
9496a77 to
5a35aec
Compare
Comment on lines
231
to
241
Contributor
There was a problem hiding this comment.
We will need to change this later because remainingCount may be greater than 0, but it's OK to leave this in here for now.
varungandhi-src
approved these changes
Jun 21, 2024
varungandhi-src
left a comment
Contributor
There was a problem hiding this comment.
Minor non-blocking comments only.
Contributor
|
We need to update the code here once https://github.com/sourcegraph/sourcegraph/pull/63371 lands |
5a35aec to
f628f3e
Compare
2b3d440 to
361026f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/GRAPH-667/wrap-up-usage-results-in-graphql-resolvers
This allows us to actually return syntactic usages from the occurrences API. It does not implement pagination yet, but I think that PR will be nicer to review after this one landed.
Requires #63268
Test plan
Running queries against the site-admin api console