This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: Don't mark references in import statements as definitions#63284
Merged
Conversation
kritzcreek
approved these changes
Jun 17, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Change makes sense to me, though the sparse test coverage is a bit worrying.
468f280 to
1a6d3d6
Compare
Contributor
Author
|
@kritzcreek I added tests for the three different grammar constructs being targeted by the queries earlier, instead of just the one test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scip-ctags directly affects
type:symboloutput, andtype:symbolsearch iscurrently only expected to return definitions, as it is used in the symbols sidebar
(where we want to see the symbol outline for the file), as well as
type:symbolsearch directly in the search UI.
Returning references in import statements is not useful.
For more context, see https://linear.app/sourcegraph/issue/SRCH-238
This patch is limited to JS/TS only. I've filed a follow-up issue for looking at
other languages here: https://linear.app/sourcegraph/issue/GRAPH-687
Test plan
Added new snapshot test
Changelog
type:symbolsearch.