feat(ci): Trigger security scanner from release pipeline#63280
Conversation
craigfurman
left a comment
There was a problem hiding this comment.
🚀 Sweet!
Is --pretend enough to truly test this? It doesn't trigger the pipeline that will run this step, if I understand correctly?
Could we create an internal release to kick the tires on this before the next real release, or is that too heavyweight?
Kicking off an internal release to test this seems like a good idea to me 🚢 |
|
I'll kick off an internal release too, y'all right! I also just remembered this step runs on Buildkite, so I'm gonna need to put the secret into secrets manager and import it in https://github.com/sourcegraph/infrastructure |
|
Triggered a development build with security scanning enabled: https://buildkite.com/sourcegraph/sourcegraph/builds/279073 |
Resolves REL-100 by calling the security scanner as part of the release pipeline, during the internal image creation time.
@willdollman kindly dropped me some notes on how to use this, notably in this PR I've removed
dryRun=truegiven how this will only be run from the release process. I'm also using atagwith noimageslisted.I've added the token will sent me to 1Password under
image-scanner-webhookand added a check to ensure it exists when being called.Will's Notes:
Test plan
Ran
sg release create --version=auto --pretendto ensure the script still worksChangelog