This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(ci): remove broken glob#63277
Merged
Merged
Conversation
vdavid
approved these changes
Jun 14, 2024
vdavid
left a comment
Contributor
There was a problem hiding this comment.
No idea what I'm stamping
jk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A glob that doesn't match any files got introduced in https://github.com/sourcegraph/sourcegraph/commit/4077b3ec22dad1c93675fd3e33336a35019bac00#diff-f7c1ab1acb5e753bccdd4b092b0098fa58855899e8764b68829ada2ba9cea760R147 which appears to confuse Gazelle, leading to
sg bazel configurenot updating ts files.Fixes https://github.com/sourcegraph/devx-support/issues/1029
Test plan
Locally tested:
client/web/src/cody/subscription/subscriptionSummary.tssg bazel configureChangelog