This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search): Improve syntax highlighting of search history entries#63271
Merged
camdencheek merged 1 commit intoJun 14, 2024
Merged
Conversation
Currently queries are assumed to be 'literal', but in the current apps we mostly use 'keyword' and 'standard'. Ideally we could pass the pattern type that was used for each history entry, but we don't have that information and cannot pass it easily. Defaulting to the 'standard' or 'keyword' type is the next best option to ensure that regex literal in the query are properly highlighted. I defaulted to 'standard' in the React app because it's still possible to opt out of keyword search.
camdencheek
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-404
Currently queries are assumed to be 'literal', but in the current apps we mostly use 'keyword' and 'standard'. Ideally we could pass the pattern type that was used for each history entry, but we don't have that information and cannot pass it easily.
Defaulting to the 'standard' or 'keyword' type is the next best option to ensure that regex literal in the query are properly highlighted.
I defaulted to 'standard' in the React app because it's still possible to opt out of keyword search.
Test plan
Manual testing.