Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Add specialized function for sorting primitive sets#63269

Merged
varungandhi-src merged 2 commits into
mainfrom
vg/sorting
Jun 17, 2024
Merged

chore: Add specialized function for sorting primitive sets#63269
varungandhi-src merged 2 commits into
mainfrom
vg/sorting

Conversation

@varungandhi-src

Copy link
Copy Markdown
Contributor

The most common case is sorting primitives, so add a specialized
function for that which doesn't require passing in a comparator explicitly.

Test plan

Updated existing tests

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jun 14, 2024
@github-actions github-actions Bot added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform labels Jun 14, 2024
@varungandhi-src varungandhi-src enabled auto-merge (squash) June 14, 2024 13:54

@kritzcreek kritzcreek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small formatting nit

Comment thread internal/collections/set.go
@varungandhi-src varungandhi-src merged commit 8c83b5f into main Jun 17, 2024
@varungandhi-src varungandhi-src deleted the vg/sorting branch June 17, 2024 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants