This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search): Better diagnostic message for invalid and incomplete select: filter value#63266
Merged
fkling merged 1 commit intoJun 15, 2024
Merged
Conversation
…ect: filter value
camdencheek
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srch-362
When the select filter value ends with a
.and does not have a valid "top-level" value, e.g.select:diff.then the diagnostic message doesn't show a list of valid values. This commit fixes that.Additionally it won't show an empty tooltip anymore when we don't have information for the hovered token.
(notice the separator in the popover in the first screenshot)
This affects both the React and the Svelte app.
Test plan
Manual testing.
Changelog
select:value is entered