This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): scrolling search input#63261
Merged
Merged
Conversation
fkling
approved these changes
Jun 14, 2024
fkling
left a comment
Contributor
There was a problem hiding this comment.
I'd expect CodeMirror to handle this itself but maybe we set a fixed height on the input already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SRCH-541
Reported here
The bug:
screenshot-2024-06-13_20-06-49.mp4
With the change in font, the minimum line-height to fit that font has also increased. 1.6 seemed to do the job.
I'm a little concerned about other places this might be a problem, but for now just doing the easy thing to make it feel less broken.
Test plan
The input no longer scrolls and there is no change to the height of the element as a whole.