This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(codeintel): Use internal language detection package for insights#63254
Merged
mmanela merged 10 commits intoJun 17, 2024
Merged
Conversation
camdencheek
reviewed
Jun 13, 2024
camdencheek
reviewed
Jun 13, 2024
camdencheek
reviewed
Jun 13, 2024
camdencheek
approved these changes
Jun 14, 2024
varungandhi-src
suggested changes
Jun 14, 2024
varungandhi-src
left a comment
Contributor
There was a problem hiding this comment.
Please remove the GetFirstMatchingLanguage function.
…e-insights-code-to-use-languages-go-enry-wrapper
…ges-go-enry-wrapper' of https://github.com/sourcegraph/sourcegraph into mattmanela/graph-663-update-insights-code-to-use-languages-go-enry-wrapper
varungandhi-src
approved these changes
Jun 17, 2024
Contributor
…-use-languages-go-enry-wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates two more places to use the common language detection package (which wraps go-enry) instead of using go-enry directly. This provides us more flexibility and ensures a consistent mechanisms across the product.
Test plan
Changelog