This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(plg): Apply designs to Cody Pro pages#63244
Merged
Merged
Conversation
Contributor
Author
|
I've addressed everything in the QA section. I left a few questions in the figma but also did my best effort to guess the answers. "Upgrade to Cody Pro" bannerDarkLightCheckout formNote: I haven't found a way to control the font weight on the address field labels, so other labels are weight:500, and address field labels are weight:400. DarkLightManage subscription pageDarkLightCody manage page with welcome bannerDarkLight |
chrsmith
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were many occasions where the designs didn't adhere to the figma. This PR intends to fix most of those cases.
For reviewers:
.there. I could call it3-25, or get rid of it altogether if you say it's a terrible idea, but I already had to use the new,1.125rem=18pxspace at 6 places, and @rrhyne uses it a lot in the Figma so I suspect we'll need it at a bunch more places, so would be nice to have that utility class available.This PR does three things:
Screenshot
Screenshot
Two screenshots
I chose to create this PR early despite everything being 100% there with the design changes for three reasons:
Test plan
All low-risk changes.
I did manual QA.
See the screenshots.