Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(plg): Apply designs to Cody Pro pages#63244

Merged
vdavid merged 18 commits into
mainfrom
dv/ssc-fix-css
Jun 19, 2024
Merged

feat(plg): Apply designs to Cody Pro pages#63244
vdavid merged 18 commits into
mainfrom
dv/ssc-fix-css

Conversation

@vdavid

@vdavid vdavid commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

There were many occasions where the designs didn't adhere to the figma. This PR intends to fix most of those cases.

For reviewers:

This PR does three things:

  1. Fixes https://github.com/sourcegraph/sourcegraph/issues/63038
Screenshot

CleanShot 2024-06-13 at 13 18 56@2x

  1. Fixes https://github.com/sourcegraph/sourcegraph/issues/63245
Screenshot

CleanShot 2024-06-13 at 13 35 29@2x

  1. Does most of https://github.com/sourcegraph/sourcegraph/issues/63039, although not perfect.
Two screenshots

CleanShot 2024-06-13 at 17 50 48@2x

CleanShot 2024-06-13 at 17 34 44@2x

I chose to create this PR early despite everything being 100% there with the design changes for three reasons:

  1. To surely ship my progress before my parental leave
  2. To avoid big conflicts with other PRs (I already have another one under review that conflicts with this at a few places)
  3. To help @taras-yemets use the new utility classes at other places.

Test plan

All low-risk changes.
I did manual QA.
See the screenshots.

@cla-bot cla-bot Bot added the cla-signed label Jun 13, 2024
@vdavid vdavid marked this pull request as ready for review June 13, 2024 16:01
@vdavid vdavid requested review from a team, rrhyne and taras-yemets June 13, 2024 16:05
@rrhyne

rrhyne commented Jun 14, 2024

Copy link
Copy Markdown

QA here:
https://www.figma.com/design/FMSdn1oKccJRHQPgf7053o/Cody-PLG-GA?node-id=5458-16240&t=ndgEZFI57dVTIBpo-4

@vdavid

vdavid commented Jun 18, 2024

Copy link
Copy Markdown
Contributor Author

@rrhyne:

I've addressed everything in the QA section. I left a few questions in the figma but also did my best effort to guess the answers.

"Upgrade to Cody Pro" banner

Dark

CleanShot 2024-06-18 at 14 35 05@2x

Light

CleanShot 2024-06-18 at 14 35 50@2x

Checkout form

Note: I haven't found a way to control the font weight on the address field labels, so other labels are weight:500, and address field labels are weight:400.

Dark

CleanShot 2024-06-18 at 15 04 23@2x

Light

CleanShot 2024-06-18 at 15 04 50@2x

Manage subscription page

Dark

CleanShot 2024-06-18 at 15 29 40@2x

Light

CleanShot 2024-06-18 at 15 30 12@2x

Cody manage page with welcome banner

Dark

CleanShot 2024-06-18 at 15 30 56@2x

Light

CleanShot 2024-06-18 at 15 30 31@2x

@vdavid vdavid merged commit 0e3a85f into main Jun 19, 2024
@vdavid vdavid deleted the dv/ssc-fix-css branch June 19, 2024 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Invite co-workers" button is missing Fix icon background shadow

3 participants