Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(Search): Add icon for the Hack language#63233

Merged
mmanela merged 7 commits into
mainfrom
mmanela/graph-620-hack-icon-for-language
Jun 13, 2024
Merged

feat(Search): Add icon for the Hack language#63233
mmanela merged 7 commits into
mainfrom
mmanela/graph-620-hack-icon-for-language

Conversation

@mmanela

@mmanela mmanela commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

Fixes GRAPH-620

Adds the icon for the Hack language to the Svelte UI

image

image

Test plan

  • Validate on UX
  • Ensure client side tests pass

Changelog

  • Adds icon for the Hack language

@mmanela mmanela requested review from camdencheek and fkling June 12, 2024 19:17
@cla-bot cla-bot Bot added the cla-signed label Jun 12, 2024
@mmanela mmanela changed the title feat(Search): Add icon for Hack language feat(Search): Add icon for the Hack language Jun 12, 2024

@camdencheek camdencheek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!

@fkling

fkling commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

There seem to be quite a lot of unrelated changes in the pnpm lock file. I suggest du revert those changes and reinstall the icon set. The dependency has to be added to the bazel build file too.

@mmanela mmanela merged commit a3a6545 into main Jun 13, 2024
@mmanela mmanela deleted the mmanela/graph-620-hack-icon-for-language branch June 13, 2024 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants