This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Proof-of-concept for Intent detector API#63228
Merged
Merged
Conversation
Member
|
naming nits (not blocking):
|
Contributor
Author
I followed the naming convention from the other method on the same resolver (GetCodyContext that takes a GetContextArgs), but I agree, depending on the next steps I'll either fix this or will move it to a more permanent place (this should really be a part of the upcoming Context API). |
rafax
referenced
this pull request
Jun 28, 2024
…63416) Address remarks from https://github.com/sourcegraph/sourcegraph/pull/63228#issuecomment-2163682435 ## Test plan - tested locally - old code not deleted yet (until I confirm it's ok to remove it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GraphQL endpoint for intend-detection - Slack [context]
Test plan