This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: remove v1 telemetry#63220
Merged
Merged
Conversation
camdencheek
commented
Jun 12, 2024
Member
Author
There was a problem hiding this comment.
No real diff here. Just renamed telemetry2.ts to telemetry.ts and removed the old one. No reason to keep V2 in the name if there is only one version in use.
camdencheek
commented
Jun 12, 2024
Member
Author
There was a problem hiding this comment.
This one is a little funky because you can not easily select the text of search results anymore.
fkling
approved these changes
Jun 12, 2024
22bdb15 to
08eb394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SRCH-495
Test plan
Checked that we were sending V2 events for the new ones I converted. Most other issues would be caught by type checking.