This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(ci): conditionally stamp genrules#63204
Merged
Merged
Conversation
burmudar
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/bazelbuild/bazel/releases/tag/7.1.0 which introduces a new value for the stamp attribute for
genrule:stamp = -1which makes the stamping conditional.Previously, any genrule that had
stamp = 1would be stamping all the time due to how it was implemented prior 7.1. An as we stamp builds with a computed version that is date dependent, we would never get cache hits on those, leading to//cmd/migrator:image_testbeing executed all the time. It wasn't that big of an issue as it's rather quick, but still.Now the
genrulesupports that there's no reason to fix that one.Test plan
CI
Changelog