Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

sg: cloud eph - set max deployment name#63202

Merged
burmudar merged 2 commits into
mainfrom
wb/sg/cloud-eph-max-name
Jun 11, 2024
Merged

sg: cloud eph - set max deployment name#63202
burmudar merged 2 commits into
mainfrom
wb/sg/cloud-eph-max-name

Conversation

@burmudar

Copy link
Copy Markdown
Contributor

Encountered this error while doing my demo

{"SeverityText":"ERROR","Timestamp":1718110348252114099,"InstrumentationScope":"mi2.instance.create","Caller":"mi2/instance.go:478","Function":"main.glob..func26","Body":"new instance validation failed: slug (displayName) must be between 4 to 30 characters. Allowed characters are: lowercase letters, numbers, hyphen. Current: christoph-resolve-syntactic-symbol-at-request-range","Resource":{"service.name":"mi2","service.version":"2024-06-11-09-50-

So now we limit it to 30 chars and print a notice to inform the user that it has been truncated

Test plan

Tested locally

go run ./dev/sg cloud eph deploy --name 'christoph-resolve-syntactic-symbol-at-request-range_277899_2024-06-11_5.4-f04d3b973a19' --version 'christoph-resolve-syntactic-symbol-at-request-range_277899_2024-06-11_5.4-f04d3b973a19'
✅ Version "christoph-resolve-syntactic-symbol-at-request-range_277899_2024-06-11_5.4-f04d3b973a19" found in Cloud ephemeral registry
👉 Your deployment name has been truncated to be "christoph-resolve-syntactic-sy"

Changelog

  • sg - set a max length for cloud ephemeral deployment names

@burmudar burmudar requested review from a team and filiphaftek June 11, 2024 13:58
@burmudar burmudar self-assigned this Jun 11, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 11, 2024
@burmudar burmudar merged commit 9b37349 into main Jun 11, 2024
@burmudar burmudar deleted the wb/sg/cloud-eph-max-name branch June 11, 2024 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants