Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

sg: cloud eph - improve missing tag/version message#63195

Merged
burmudar merged 2 commits into
mainfrom
wb/sg/improve-missing-version-msg
Jun 11, 2024
Merged

sg: cloud eph - improve missing tag/version message#63195
burmudar merged 2 commits into
mainfrom
wb/sg/improve-missing-version-msg

Conversation

@burmudar

Copy link
Copy Markdown
Contributor

Previous message didn't give you steps to get the version added. New message directs you to discuss-dev-infra slack which will ultimately run https://buildkite.com/sourcegraph/cloud-ephemeral-images

Test plan

CI and tested locally

go run ./dev/sg cloud eph deploy --version 1.1.1
⚠️ Whoops! Version "1.1.1" seems to be missing from the Cloud ephemeral registry. Please ask in #discuss-dev-infra to get the it added to the registry
❌ tag/version not in Cloud Ephemeral registry
exit status 1

Changelog

  • sg - improve messaging when an image is missing from Cloud ephemeral registry

@burmudar burmudar requested review from a team and filiphaftek June 11, 2024 08:46
@burmudar burmudar self-assigned this Jun 11, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 11, 2024

@filiphaftek filiphaftek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@burmudar burmudar merged commit 4f910fb into main Jun 11, 2024
@burmudar burmudar deleted the wb/sg/improve-missing-version-msg branch June 11, 2024 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants