Fix(search): querying event logs breaks when "id" column value > int32#63193
Conversation
Because the underlying database column is `bigint`, and large enough values in it (showed up on dotcom) broke event log queries.
Seemed to affect build files not related to my changes, so might need to revert this commit?
camdencheek
left a comment
There was a problem hiding this comment.
Not a full review, but do we expose this via the GraphQL int type? IIRC, those must be int32 per GraphQL spec.
The |
camdencheek
left a comment
There was a problem hiding this comment.
Thanks for the fix!
While we're at it, we might want to change AfterID to be an explicit int64 since it refers to the same column
|
Hmm, good point about I think I'll leave it alone for now, but create a followup issue to document it. |
|
We expect that indexer job to also be broken then, right? Because the jobs it's storing will overflow the bookmark column type? |
On certain systems, yes, it's probably broken. |
When querying
SearchResultsQueriedevents on dotcom, got the error:Turns out the Event struct's ID column is
int32, while the underlying database column isbigint, which corresponds to Go'sint64.Changed the Event struct's
IDcolumn toint64.Added a test to check handling of 64-bit integers.
Test plan
Automated tests should pass.
New test should pass.
run this GraphQL query using a valid user ID (can be gotten from a
currentUserquery)Changelog