This repository was archived by the owner on Sep 30, 2024. It is now read-only.
dotcom: fix issue with dotcom emails#63183
Merged
Merged
Conversation
2c6d037 to
6ce6ae8
Compare
eseliger
approved these changes
Jun 10, 2024
|
|
||
| cleanedName := strings.ReplaceAll(strings.ToLower(name), " ", "") | ||
|
|
||
| return url.PathEscape(unicodeToAscii(cleanedName)) + "@noreply.sourcegraph.com", nil |
Member
There was a problem hiding this comment.
just triple checking that we're fine to give our top domain away for that :)
Contributor
There was a problem hiding this comment.
It's a fake address and we are not receiving emails for real so we are not really using it, should be fine? 😂
Contributor
Author
There was a problem hiding this comment.
it will bounce in case of spammers trying it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to https://github.com/sourcegraph/security-issues/issues/392#issuecomment-2158160741 for more information about this dotcom specific change.
Test plan
CI tests