This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.4.5099] release: never use build number in image family#63178
Merged
Conversation
the executor image and docker mirror image should now follow the following naming convention: Image family: `sourcegraph-executors-[nightly|internal|'']-<MAJOR>-<MINOR>` Image name: `sourcegraph-executor-[nightly|internal|'']-<MAJOR>-<MINOR>-<BUILD_NUMBER>` example: Image family: `sourcegraph-executors-5-4` Image name: `sourcegraph-executor-5-4-277666` ## What happens during releases and _not_ releases? #### Nightly **`nightly` suffix** Image family: `sourcegraph-executors-nightly-<MAJOR>-<MINOR>` Image name: `sourcegraph-executor-nightly-<MAJOR>-<MINOR>-<BUILD_NUMBER>` #### Internal **`internal` suffix** Image family: `sourcegraph-executors-internal-<MAJOR>-<MINOR>` Image name: `sourcegraph-executor-internal-<MAJOR>-<MINOR>-<BUILD_NUMBER>` #### Public / Promote to public ** No suffix ** Image family: `sourcegraph-executors-<MAJOR>-<MINOR>` Image name: `sourcegraph-executor-<MAJOR>-<MINOR>-<BUILD_NUMBER>` > [!IMPORTANT] > Should we keep the imagine name stable at `sourcegraph-executor-<MAJOR>-<MINOR>-<BUILD_NUMBER>` > and only change the family name? > > **Why?** > > The Image family dictates the collection of images and that changes each major minor and or release phase so there is really no use in changing the image name too, except at a glance you can see from the name what image family it belongs to? ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles --> ## Changelog <!-- 1. Ensure your pull request title is formatted as: $type($domain): $what 2. Add bullet list items for each additional detail you want to cover (see example below) 3. You can edit this after the pull request was merged, as long as release shipping it hasn't been promoted to the public. 4. For more information, please see this how-to https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c? Audience: TS/CSE > Customers > Teammates (in that order). Cheat sheet: $type = chore|fix|feat $domain: source|search|ci|release|plg|cody|local|... --> <!-- Example: Title: fix(search): parse quotes with the appropriate context Changelog section: ## Changelog - When a quote is used with regexp pattern type, then ... - Refactored underlying code. --> (cherry picked from commit 8bb0ab5)
Contributor
|
FYI @sourcegraph/release |
craigfurman
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the executor image and docker mirror image should now follow the following naming convention:
Image family:
sourcegraph-executors-[nightly|internal|'']-<MAJOR>-<MINOR>Image name:
sourcegraph-executor-[nightly|internal|'']-<MAJOR>-<MINOR>-<BUILD_NUMBER>example:
Image family:
sourcegraph-executors-5-4Image name:
sourcegraph-executor-5-4-277666What happens during releases and not releases?
Nightly
nightlysuffixImage family:
sourcegraph-executors-nightly-<MAJOR>-<MINOR>Image name:
sourcegraph-executor-nightly-<MAJOR>-<MINOR>-<BUILD_NUMBER>Internal
internalsuffixImage family:
sourcegraph-executors-internal-<MAJOR>-<MINOR>Image name:
sourcegraph-executor-internal-<MAJOR>-<MINOR>-<BUILD_NUMBER>Public / Promote to public
** No suffix **
Image family:
sourcegraph-executors-<MAJOR>-<MINOR>Image name:
sourcegraph-executor-<MAJOR>-<MINOR>-<BUILD_NUMBER>> [!IMPORTANT]
> Should we keep the imagine name stable at
sourcegraph-executor-<MAJOR>-<MINOR>-<BUILD_NUMBER>> and only change the family name?
>
> Why?
>
> The Image family dictates the collection of images and that changes each major minor and or release phase so there is really no use in changing the image name too, except at a glance you can see from the name what image family it belongs to?
Test plan
Changelog
Backport 8bb0ab5 from #63157