Svelte: add footer links for dotcom#63170
Conversation
6672284 to
f7b8505
Compare
| name: 'Docs', | ||
| href: 'https://sourcegraph.com/docs', | ||
| handleClick: () => handleLinkClick('Docs'), |
There was a problem hiding this comment.
I kind of want to simplify this so that we don't have to define a separate function for every link. But since the links are actually not rendered here, I'm not sure what the best way would be.
Does the list have to be defined here though? Or can we move it to SearchHome? What was your thought process behind putting them here?
There was a problem hiding this comment.
Yeah, I started with a generic "links" element where we pass the data in. But I thought the typing of the telemetry recorder was more sophisticated than it is.
I just refactored this so this is just a "DotcomLinksFooter" so we can isolate the relevant data. In the case that we ever end up using this for self-hosted instances, we can genericize it.
1ffd556 to
c3e5e18
Compare
c3e5e18 to
18d6a80
Compare
| href: 'https://sourcegraph.com/security', | ||
| telemetryType: 5, |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: security-semgrep-rules.semgrep-rules.generic.comment-tagging-rule
Stacked on #63167
Completes SRCH-493
Test plan
https://share.cleanshot.com/LLQCYdTY