This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(cody-gateway): add Google Gemini stable models to allowed models#63163
Merged
Conversation
This change adds the stable versions of the Google Gemini 1.5 Flash, Gemini 1.5 Pro, and Gemini Pro models to the list of allowed models in the Cody Gateway configuration and API endpoints. The changes are made in the following files: - `cmd/cody-gateway/shared/config/config.go` - `cmd/frontend/internal/dotcom/productsubscription/codygateway_dotcom_user.go` - `cmd/frontend/internal/httpapi/completions/chat.go` - `internal/conf/computed.go` The new models are added to the allowed model lists and also set as the default chat, fast chat, and completion models when the configuration is not explicitly set. This change ensures that users are defaulted to use the stable versions of the Google Gemini models with the latest versions are still being available for use in the Cody Gateway application.
chrsmith
approved these changes
Jun 7, 2024
chrsmith
left a comment
Contributor
There was a problem hiding this comment.
I have no idea if this is the complete list, of if you need to add Gemini to a few more places. 🤷 But this LGTM.
When this is rolled out, I believe the last (and final?) step is to just add Gemini to the shared/model package's dotcom.ts in the sourcegraph/cody repo? And then it's totally official?
Contributor
Author
Thanks for the review and YES! I believe it's official after that!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the stable versions of the Google Gemini 1.5 Flash, Gemini 1.5 Pro, and Gemini Pro models to the list of allowed models in the Cody Gateway configuration and API endpoints.
The changes are made in the following files:
cmd/cody-gateway/shared/config/config.gocmd/frontend/internal/dotcom/productsubscription/codygateway_dotcom_user.gocmd/frontend/internal/httpapi/completions/chat.gointernal/conf/computed.goThe new models are added to the allowed model lists and also set as the default chat, fast chat, and completion models when the configuration is not explicitly set.
This change ensures that users are defaulted to use the stable versions of the Google Gemini models with the latest versions are still being available for use in the Cody Gateway application.
Test plan
Changes are covered by current tests.
Changelog