This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterprise-portal: return all attributes, even when access is disabled#63159
Merged
Conversation
ba90661 to
b92e6dd
Compare
unknwon
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing a more in-depth, final check between the state of sync in dotcom and in Enterprise Portal, and found a discrepancy: we only return attributes if access is enabled, but there are Cody Gateway features that are enabled even if Cody Gateway access is disabled. This was also called out in https://github.com/sourcegraph/sourcegraph/pull/62934#discussion_r1625142452
See my comment in CORE-98 here: https://linear.app/sourcegraph/issue/CORE-98/enterprise-portal-use-portal-from-cody-gateway#comment-80991a40
Test plan
Basic unit test to make sure the constructor doesn't blow up on any nil fields