This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.4.5099] fix(release): remove generate-notes from github r…#63148
Merged
Conversation
…elease creation (#63121) Generate notes currently generates a changelog all the way from the tag `app-2023` ... which means the content is more than what is allowed by github - hard cap of 125000 characters. - remove `generate-notes` cli flag when promoting releases - push only a single tag - fix token name used in changelog generation (cherry picked from commit 817738a)
burmudar
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate notes currently generates a changelog all the way from the tag
app-2023... which means the content is more than what is allowed bygithub - hard cap of 125000 characters.
(cherry picked from commit 817738a)
Also backports https://github.com/sourcegraph/sourcegraph/pull/63119 (@DaedalusG)
Test plan
This has been run in one release.
Changelog
generate-notescli flag when promoting releases