This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: fix tests#63146
Merged
Merged
Conversation
fkling
approved these changes
Jun 7, 2024
|
|
||
| <div class="header" use:sizeToFit={{ grow, shrink }}> | ||
| <h2 on:copy={stripSpaces}> | ||
| <h2 on:copy={stripSpaces} data-testid="header-path"> |
Contributor
There was a problem hiding this comment.
I suggest to be even more specific hear and include the component name in the test id. Something like
Suggested change
| <h2 on:copy={stripSpaces} data-testid="header-path"> | |
| <h2 on:copy={stripSpaces} data-testid="file-header-path"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disabled a few tests to get #62560 merged. This just goes back and fixes the ones I disabled. There are still a handful skipped, but the fixes were non-trivial.
Test plan
The unskipped tests pass