This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove references to 'rate-limits-exceeded-for-testing' feature flag#63144
Merged
Conversation
andreeleuterio
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this Slack thread for some more context on this change.
Somebody pointed out that there is a Sourcegraph.com feature flag that appears to allow a user to bypass any Cody Pro rate limits that are imposed. (This was originally added in https://github.com/sourcegraph/sourcegraph/pull/58591 to facilitate testing when user limits were a new thing.)
However, at this point that capability has proven itself and so this escape hatch is no longer needed. However it sounds like this may never have worked correctly on Cody Gateway, by virtue of when feature flags get materialized, and where the specific Cody Gateway API call is made. (Slack)
Test plan
Relying on CI/CD.
Changelog