Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

build(bazel): fixup custom eslint test rule after bump to rules_js 2#63143

Merged
Strum355 merged 1 commit into
mainfrom
aspect/fix_custom_eslint_after_rules_js_2_bump
Jun 6, 2024
Merged

build(bazel): fixup custom eslint test rule after bump to rules_js 2#63143
Strum355 merged 1 commit into
mainfrom
aspect/fix_custom_eslint_after_rules_js_2_bump

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Jun 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This regressed in https://github.com/sourcegraph/sourcegraph/pull/63022 where the custom gather_files_from_js_providers function that was copied over from rules_js 1.x was including runfiles (which would have also included all sources & transitive source implicitly as well).

Resolves eslint failures seen in https://buildkite.com/sourcegraph/sourcegraph/builds/277072#018fe743-abac-44d8-911b-d5a7ed425413 and observed locally:

(07:19:15) INFO: From ESLint client/wildcard/wildcard_lib_eslint-output.txt:
  |  
  | Oops! Something went wrong! :(
  |  
  | ESLint: 8.57.0
  |  
  | ESLint couldn't find a configuration file. To set up a configuration file for this project, please run:
  |  
  | npm init @eslint/config
  |  
  | ESLint looked for configuration files in /tmp/bazel-working-directory/__main__/bazel-out/k8-fastbuild/bin/client/wildcard/src/components/Alert and its ancestors. If it found none, it then looked in your home directory.
  |  
  | If you think you already have a configuration file or if you need more help, please stop by the ESLint Discord server: https://eslint.org/chat

Test plan

CI (check test logs)

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jun 6, 2024
@gregmagolan gregmagolan force-pushed the aspect/fix_custom_eslint_after_rules_js_2_bump branch from 35f7319 to 9dfb260 Compare June 6, 2024 22:19
@gregmagolan gregmagolan force-pushed the aspect/fix_custom_eslint_after_rules_js_2_bump branch from 9dfb260 to 27b0cfe Compare June 6, 2024 22:22
@gregmagolan gregmagolan requested a review from Strum355 June 6, 2024 22:25
Strum355
Strum355 approved these changes Jun 6, 2024
View reviewed changes

@Strum355 Strum355 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the job ty! 🙏

@Strum355 Strum355 merged commit 27da789 into main Jun 6, 2024
@Strum355 Strum355 deleted the aspect/fix_custom_eslint_after_rules_js_2_bump branch June 6, 2024 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Strum355 Strum355 Strum355 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregmagolan @Strum355