This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterprise-portal: rudimentary audit logging#63142
Merged
Conversation
e43532b to
3424a02
Compare
unknwon
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we prepare to roll out https://github.com/sourcegraph/sourcegraph/pull/62934, this adds rudimentary audit logging that records the client and some session details on successful data access at the end of the RPC. The GraphQL resolvers generate an audit log on every resolver, so this maintains some parity.
I'm not sure there's a good way to generalize this better and reduce copy-pasta, open to ideas
Test plan
n/a just logging additions