This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(highlighting): Update JSX/TSX highlighting to more properly label tag delimiters#63138
Merged
Conversation
d24ffd3 to
7904db3
Compare
7904db3 to
442c64f
Compare
442c64f to
597d44b
Compare
varungandhi-src
approved these changes
Jun 7, 2024
Contributor
There was a problem hiding this comment.
Are you planning to fix the CSS in this PR or a different PR? It still says TagDelimited instead of TagDelimiter on main.
(Also, I noticed you're using the search area for highlighting PRs, but it's technically incorrect, because this highlighting does not actually affect highlighting for search results, which go through a different code path.)
Contributor
Author
|
Thanks for calling that out, I can fix in this PR @varungandhi-src |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update JSX/TSX highlighting to identify tag delimiters properly.
Test plan
Changelog