Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix(SCIM): don't allow SCIM users to change fields#63130

Merged
evict merged 2 commits into
mainfrom
vincent/fix-scim-override
Jun 6, 2024
Merged

fix(SCIM): don't allow SCIM users to change fields#63130
evict merged 2 commits into
mainfrom
vincent/fix-scim-override

Conversation

@evict

@evict evict commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

Previously it was possible to use the updateUser mutation to change user fields for SCIM managed users. We now reject these changes if the user is SCIM managed.

Test plan

CI tests

@evict evict requested a review from a team June 6, 2024 17:27
@evict evict self-assigned this Jun 6, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 6, 2024
@evict evict changed the title fix: don't allow SCIM users to change fields fix(SCIM): don't allow SCIM users to change fields Jun 6, 2024
@evict evict added the SSDLC label Jun 6, 2024
Comment thread cmd/frontend/graphqlbackend/user.go
@evict evict requested a review from eseliger June 6, 2024 18:05

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tests!

@evict evict merged commit c157fa8 into main Jun 6, 2024
@evict evict deleted the vincent/fix-scim-override branch June 6, 2024 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants