This repository was archived by the owner on Sep 30, 2024. It is now read-only.
svelte: Migrate repo sidebar toggle button to use lucide icon#63129
Merged
Conversation
taiyab
reviewed
Jun 6, 2024
Contributor
Author
I felt that would be inconsistent then with the bottom panel one. It's the same icon size, so why would it work in one case but not the other? |
Contributor
|
Yea, it is inconsistent, and I get that. The down arrow panel one doesn't feel as immediately understandable, maybe because of the position of the arrow, or the my own personal lack of familiarity or association with that icon meaning anything to me immediately. Let's do the panel one for the left, and the line arrow one for the bottom panel and see how that feels. (FYI, I'm not able to test these locally as I'm having setup issues, I'd be able to give you a better answer if I could!) |
camdencheek
approved these changes
Jun 7, 2024
5065c34 to
4eaf759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title.
Contributes to SRCH-467
Test plan
Visual inspection.