This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/sg-msp-pg: add suggestion to check msp-ops page on perms error#63118
Merged
Conversation
unknwon
approved these changes
Jun 6, 2024
DaedalusG
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think finding the right permissions confuses people pretty often when first interacting with MSP. This adds a helper for annotating errors returned from points where we might be able to help out @DaedalusG, specifically for the situation in https://sourcegraph.slack.com/archives/C05GJPTSZCZ/p1717629546727829 😉
Test plan
It's a little wordy but:
Changelog
sg msp pg connectwill tell you about your service's generated Notion page if you run into a permissions-looking error during command setup, where there is guidance about the required Entitle requests.