Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

bazel: rules_js rc3 and remove deprecated "exclude_declarations" option#63095

Merged
burmudar merged 1 commit into
mainfrom
wb/bazel/deprecated-opt
Jun 5, 2024
Merged

bazel: rules_js rc3 and remove deprecated "exclude_declarations" option#63095
burmudar merged 1 commit into
mainfrom
wb/bazel/deprecated-opt

Conversation

@burmudar

@burmudar burmudar commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

exclude_declarations_from_npm_packages is not an option anymore as from the output

ERROR: @aspect_rules_js//npm:exclude_declarations_from_npm_packages :: Unrecognized option: @aspect_rules_js//npm:exclude_declarations_from_npm_packages

Also upgraded to rc3 while diagnosing this.

Closes https://github.com/sourcegraph/devx-support/issues/1005

Test plan

Tested locally + CI

sg bazel test //internal/appliance/reconciler:reconciler_test
INFO: Invocation ID: 70da4295-36f2-43a8-a71e-9b11ae489657
WARNING: Build option --modify_execution_info has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed).
INFO: Analyzed target //internal/appliance/reconciler:reconciler_test (0 packages loaded, 17313 targets configured).
INFO: Found 1 test target...
Target //internal/appliance/reconciler:reconciler_test up-to-date:
  bazel-bin/internal/appliance/reconciler/reconciler_test_/reconciler_test
Aspect @@rules_rust//rust/private:rustfmt.bzl%rustfmt_aspect of //internal/appliance/reconciler:reconciler_test up-to-date (nothing to build)
Aspect @@rules_rust//rust/private:clippy.bzl%rust_clippy_aspect of //internal/appliance/reconciler:reconciler_test up-to-date (nothing to build)
INFO: Elapsed time: 1.210s, Critical Path: 0.11s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//internal/appliance/reconciler:reconciler_test                 (cached) PASSED in 19.2s

Changelog

  • remove deprecated option exclude_declarations_from_npm_packages from local.bazelrc
  • update to rc3 of rules_js

@burmudar burmudar requested review from a team and craigfurman June 5, 2024 08:24
@burmudar burmudar self-assigned this Jun 5, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 5, 2024
Strum355
Strum355 approved these changes Jun 5, 2024
View reviewed changes

@Strum355 Strum355 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One to ask aspect crew about? 🤔

@burmudar burmudar changed the title bazel: rules_js rc2 and remove deprecated "exclude_declarations" option bazel: rules_js rc3 and remove deprecated "exclude_declarations" option Jun 5, 2024
@burmudar

burmudar commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

One to ask aspect crew about? 🤔

Yeah I'll post over there too

craigfurman
craigfurman approved these changes Jun 5, 2024
View reviewed changes

@craigfurman craigfurman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Tested with go run ./dev/sg bazel test //internal/appliance/reconciler:reconciler_test

@burmudar burmudar merged commit 224b3e5 into main Jun 5, 2024
@burmudar burmudar deleted the wb/bazel/deprecated-opt branch June 5, 2024 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@craigfurman craigfurman craigfurman approved these changes

@Strum355 Strum355 Strum355 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@burmudar burmudar

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burmudar @craigfurman @Strum355