Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix(sg): fix cloud eph suggested commands #63093

Merged
burmudar merged 2 commits into
mainfrom
wb/sg-cloud/fix-suggestions
Jun 7, 2024
Merged

fix(sg): fix cloud eph suggested commands #63093
burmudar merged 2 commits into
mainfrom
wb/sg-cloud/fix-suggestions

Conversation

@burmudar

@burmudar burmudar commented Jun 5, 2024

Copy link
Copy Markdown
Contributor
  • suggested commands didn't have the ephemeral subcommand
  • update expiry time to show in duration till expiry

Test plan

Tested locally + CI

Changelog

  • fix suggested cloud ephemeral commands
  • show duration till expiry for cloud ephemeral

also update expiry time to show in duration till expiry
@burmudar burmudar requested review from a team and filiphaftek June 5, 2024 07:31
@burmudar burmudar self-assigned this Jun 5, 2024
@cla-bot cla-bot Bot added the cla-signed label Jun 5, 2024
@burmudar burmudar enabled auto-merge (squash) June 5, 2024 07:35

@filiphaftek filiphaftek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@burmudar burmudar merged commit f727170 into main Jun 7, 2024
@burmudar burmudar deleted the wb/sg-cloud/fix-suggestions branch June 7, 2024 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants