This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: collapse path when too long#63082
Merged
Merged
Conversation
camdencheek
commented
Jun 4, 2024
Member
Author
There was a problem hiding this comment.
This is no longer used. Since I think the sizeToFit action is more general (grow/shrink can apply a class name), I went ahead and deleted it.
26231ed to
1eae87e
Compare
1eae87e to
aeec2ed
Compare
fkling
approved these changes
Jun 5, 2024
fkling
left a comment
Contributor
There was a problem hiding this comment.
This is amazing :) It could make sense to keep showing a prefix of the path, but we can always iterate on that.
Member
Author
Thank you 🙂 I was pleased with how well this worked out
Yeah, agreed. The logic got more annoying that way though, so I figured I should start simple and easy to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the
sizeToFitaction to the file header, allowing us to collapse the header in multiple steps:Test plan
Mostly manual testing. Video demo. Specifically tested that jumps in screen size work as expected.