This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Rename Contains to IsSupersetOf#63062
Merged
Merged
Conversation
|
(Notifying @sourcegraph/source of a change that affects gitserver) |
The name Contains is also commonly used for checking if a set contains an element in other languages, so it leads to confusing auto-complete. Additionally, IsSupersetOf sounds more expensive, which may be the case for this operation.
ebec4a1 to
7abab69
Compare
burmudar
reviewed
Jun 4, 2024
burmudar
reviewed
Jun 4, 2024
Co-authored-by: William Bezuidenhout <william.bezuidenhout@sourcegraph.com>
burmudar
approved these changes
Jun 4, 2024
Contributor
|
not a native speaker... "A contains B" to me means |
Contributor
Author
|
In usual math terminology, "superset" includes the equals case, yes. Most math textbooks use ⊇ for superset and ⊃ for strict superset (at least one element is different). Sometimes ⊃ is used for superset and ⊋ is used for strict superset. |
Contributor
TIL, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name Contains is also commonly used for checking if a
set contains an element in other languages, so it leads to
confusing auto-complete. Additionally, IsSupersetOf sounds
more expensive, which may be the case for this operation.
Test plan
Covered by existing tests
Changelog