Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Make GetDefinitions API consistent with GetReferences etc.#63056

Merged
varungandhi-src merged 2 commits into
mainfrom
vg/consistent
Jun 4, 2024
Merged

chore: Make GetDefinitions API consistent with GetReferences etc.#63056
varungandhi-src merged 2 commits into
mainfrom
vg/consistent

Conversation

@varungandhi-src

Copy link
Copy Markdown
Contributor

Implementing precise usages on top of the existing APIs becomes easier
if they're all of the same shape.

Test plan

Covered by existing tests.

Changelog

@cla-bot cla-bot Bot added the cla-signed label Jun 4, 2024
@github-actions github-actions Bot added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform labels Jun 4, 2024

@kritzcreek kritzcreek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varungandhi-src varungandhi-src merged commit f777926 into main Jun 4, 2024
@varungandhi-src varungandhi-src deleted the vg/consistent branch June 4, 2024 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants