Svelte: Add telemetry v2 to svelte client#63041
Conversation
There was a problem hiding this comment.
@dadlerj I changed this to 'server.svelte-web' to be able select/filter out only svelte
events later on our dashboards
There was a problem hiding this comment.
Why is this part of the client name? Aren't all of our events attached to an instance anyways?
There was a problem hiding this comment.
@camdencheek are you asking about dotcom and server.<instance-name> naming?
There was a problem hiding this comment.
I'm asking why our client name has to include whether or not we're on dotcom. I think our client name should just be svelte-web, because that's what is sourcing these events. Whether or not the instance is dotcom should be determined by the instance ID attached to the event logs
There was a problem hiding this comment.
(also, if we can get rid of one more thing that is special-cased for dotcom, let's do it)
88a275a to
cd34f60
Compare
Completes SRCH-68
This PR simply adds yet another telemetry v2 usage to the svelte FE client.
Test plan
Manual testing of newly added events