Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(release): allow creation of multiple patch release events#63034

Merged
BolajiOlajide merged 3 commits into
mainfrom
bo/release-allow-creation-multiple-patch-event
Jun 3, 2024
Merged

feat(release): allow creation of multiple patch release events#63034
BolajiOlajide merged 3 commits into
mainfrom
bo/release-allow-creation-multiple-patch-event

Conversation

@BolajiOlajide

Copy link
Copy Markdown
Contributor

Before this PR, the sg release cal command only allowed one patch release per monthly release. This isn't always the case as sometimes, we have multiple patches in a month.

This PR updates the calendar config to allow multiple patch release events. This changes the structure of the config object to

...
{
            "name": "July 2024 Release",
            "branchCutDate": "2024-07-02T09:00:00-07:00",
            "monthlyReleaseDate": "2024-07-05T09:00:00-07:00",
            "patchReleaseDates": ["2024-07-22T09:00:00-07:00"]
}
...

Test plan

Manual testing

Changelog

  • Multiple patch events can now be created with the sg release cal command

@BolajiOlajide BolajiOlajide requested a review from a team June 3, 2024 11:05
@BolajiOlajide BolajiOlajide self-assigned this Jun 3, 2024
@BolajiOlajide BolajiOlajide requested review from jdpleiness and removed request for a team June 3, 2024 11:05
@cla-bot cla-bot Bot added the cla-signed label Jun 3, 2024
@BolajiOlajide BolajiOlajide requested review from a team and removed request for jdpleiness June 3, 2024 11:05
@BolajiOlajide BolajiOlajide enabled auto-merge (squash) June 3, 2024 11:05
// these dates should always be in sync with the Sourcegraph Handbook release schedule
// https://handbook.sourcegraph.com/departments/engineering/dev/process/releases/#release-schedule
// https://www.notion.so/sourcegraph/Sourcegraph-Releases-eee2a5384b0a4555adb51b439ddde35f?pvs=4
"events": [

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reordered the release events so that the recent ones appear first.

@jdpleiness jdpleiness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for hammering this out 🙏

@BolajiOlajide BolajiOlajide merged commit 9e2b561 into main Jun 3, 2024
@BolajiOlajide BolajiOlajide deleted the bo/release-allow-creation-multiple-patch-event branch June 3, 2024 15:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants