This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(release): allow creation of multiple patch release events#63034
Merged
BolajiOlajide merged 3 commits intoJun 3, 2024
Conversation
BolajiOlajide
commented
Jun 3, 2024
| // these dates should always be in sync with the Sourcegraph Handbook release schedule | ||
| // https://handbook.sourcegraph.com/departments/engineering/dev/process/releases/#release-schedule | ||
| // https://www.notion.so/sourcegraph/Sourcegraph-Releases-eee2a5384b0a4555adb51b439ddde35f?pvs=4 | ||
| "events": [ |
Contributor
Author
There was a problem hiding this comment.
I reordered the release events so that the recent ones appear first.
jdpleiness
approved these changes
Jun 3, 2024
jdpleiness
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks for hammering this out 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the
sg release calcommand only allowed one patch release per monthly release. This isn't always the case as sometimes, we have multiple patches in a month.This PR updates the calendar config to allow multiple patch release events. This changes the structure of the config object to
Test plan
Manual testing
Changelog
sg release calcommand