Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(release): rename code freeze event to branch cut event#63033

Merged
BolajiOlajide merged 1 commit into
mainfrom
bo/reword-code-freeze-cal-event
Jun 3, 2024
Merged

feat(release): rename code freeze event to branch cut event#63033
BolajiOlajide merged 1 commit into
mainfrom
bo/reword-code-freeze-cal-event

Conversation

@BolajiOlajide

@BolajiOlajide BolajiOlajide commented Jun 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Slack Context

Closes REL-124

This PR renames the Code Freeze event sent when sg release cal is run to Branch Cut. This naming change reflects the correct action carried out during this event.

The concept of a Code Freeze doesn't exist during a release.

Test plan

Manual testing

Changelog

  • Rename the calendar event Code Freeze: to Branch Cut:

@BolajiOlajide BolajiOlajide requested a review from a team June 3, 2024 09:49
@BolajiOlajide BolajiOlajide self-assigned this Jun 3, 2024
@BolajiOlajide BolajiOlajide requested review from DaedalusG and removed request for a team June 3, 2024 09:49
@cla-bot cla-bot Bot added the cla-signed label Jun 3, 2024
craigfurman
craigfurman approved these changes Jun 3, 2024
View reviewed changes

@craigfurman craigfurman left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! 🚀

btw: even better than slack context - an issue that will persist longer than our slack history 😁

Closes https://linear.app/sourcegraph/issue/REL-124/branch-cut-event-replaces-code-freeze-for-the-may-release

(follow-up: it looks like linear "closes" directives don't work from comments, only descriptions, so I manually linked this in linear)

@BolajiOlajide

BolajiOlajide commented Jun 3, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for jumping on this! 🚀

btw: even better than slack context - an issue that will persist longer than our slack history 😁

Thank you. Yeah Linear is def better.

Closes linear.app/sourcegraph/issue/REL-124/branch-cut-event-replaces-code-freeze-for-the-may-release

(follow-up: it looks like linear "closes" directives don't work from comments, only descriptions, so I manually linked this in linear)

I think there's a way to activate it. I think @camdencheek did this for Code Search, can't find the thread where it was mentioned (so tagging Camden to share the process).

@BolajiOlajide BolajiOlajide merged commit bab01cc into main Jun 3, 2024
@BolajiOlajide BolajiOlajide deleted the bo/reword-code-freeze-cal-event branch June 3, 2024 10:13
@camdencheek

camdencheek commented Jun 3, 2024

Copy link
Copy Markdown
Member

Yeah! The thread with the info is here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DaedalusG DaedalusG Awaiting requested review from DaedalusG

1 more reviewer

@craigfurman craigfurman craigfurman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BolajiOlajide BolajiOlajide

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BolajiOlajide @camdencheek @craigfurman