This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix/msp: make deadlineSeconds job-level configuration, apply in timeout#63017
Merged
Conversation
jac
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a rushed POC of MSP jobs, I did some pretty bad copy-pasting (evidenced by all the service-specific docstrings I have removed in this PR) and made a bad configuration decision here, resulting in a few issues:
schedule.deadlineis not actually applied to Cloud Run jobs, causing jobs to time out earlier than desiredschedule.deadlineis not the right place to configure a deadline, because all jobs need a configurable deadline, not just those with schedules. This change movesschedule.deadlinetodeadlineSeconds.Closes CORE-145
Test plan
Changelog
schedule.deadlineis deprecated, use the top-leveldeadlineSecondsinstead. Configured deadlines are now correctly applied as the Cloud Run job execution timeout as well.