This repository was archived by the owner on Sep 30, 2024. It is now read-only.
msp/runtime: add Job runtime#63016
Merged
Merged
Conversation
bobheadxi
reviewed
May 31, 2024
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
bobheadxi
reviewed
May 31, 2024
bobheadxi
reviewed
May 31, 2024
Member
|
@jac should we file a follow-up issue to migrate https://github.com/sourcegraph/abuse-ban-bot to this new entrypoint? |
Co-authored-by: Robert Lin <robert@bobheadxi.dev>
Member
Author
Yeah, ideally we should migrate over all msp jobs if possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have a Service runtime entrypoint which parses env, creates a logger, initialises telemetry, creates the MSP contract, etc. according to MSP conventions.
However we don't have the equivalent for Jobs which requires operators to set up everything manually.
This PR remedies the situation by adding a Job entrypoint which performs similar setup to the Service entrypoint.
Closes CORE-117
Test plan
Successfully executed a mock job in GCP using this as an entrypoint