This repository was archived by the owner on Sep 30, 2024. It is now read-only.
build(bazel): bump to rules_esbuild 0.16.0#63005
Merged
Merged
Conversation
dd57370 to
fd0a7c9
Compare
fd0a7c9 to
219032b
Compare
Strum355
reviewed
May 31, 2024
Co-authored-by: Noah S-C <noah@sourcegraph.com>
Strum355
reviewed
May 31, 2024
Strum355
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.6.0 is the minimum rules_esbuild version that support bazel-lib 2.x. After this lands, I'll put up a PR to get onto bazel-lib 2.x and after that lands that unblocks upgrading to rules_oci 2 which resolves at least some caching issues with large image artifacts.
Also pins the esbuild toolchain to esbuild 0.19.2 which should be a no-op since LATEST_ESBUILD_VERSION for rules_esbuild 0.15.3 (the version currently on main) is 0.19.2.
Both @Strum355 and I tried bumping to rules_esbuild 0.17.0+ and hit build issues (with and without the sandbox plugin enabled that was added in that version) so there is work to do there to track down what changed in the ruleset that breaks this build.
Test plan
CI
Changelog