This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(scip-syntax): Fixes a couple CLI annoyances#63002
Merged
Merged
Conversation
added 3 commits
May 31, 2024 15:25
This reports an error for invocations like `scip-syntax index --lang java`, rather than creating an empty index
keynmol
approved these changes
May 31, 2024
Contributor
|
✔️ Test ownership >= 70% again, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/GRAPH-642/scip-syntax-index-fails-for-relative-workspace-path
Test plan
Run
scip-syntax --language java --workspace .and get an index with documentsRun
scip-syntax --language javaand get an error, rather than an empty indexChangelog
Internal change. Implements QoL changes to the
scip-syntaxCLI