This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: Paper cuts for 5.5 release#62997
Merged
Merged
Conversation
4e6b6ff to
e494dff
Compare
fkling
approved these changes
May 31, 2024
fkling
left a comment
Contributor
There was a problem hiding this comment.
👍🏻 Would be nice to have before/after screenshots.
camdencheek
approved these changes
May 31, 2024
fkling
reviewed
May 31, 2024
Comment on lines
+69
to
+77
| registerHotkey({ | ||
| keys: { key: 'Esc' }, | ||
| ignoreInputFields: false, | ||
| handler: event => { | ||
| event.preventDefault() | ||
| fuzzyFinderState.update(state => ({ ...state, open: false })) | ||
| return false | ||
| }, | ||
| }) |
Contributor
There was a problem hiding this comment.
We should already get this behavior for free via the <dialog> component. At least it works for me in Firefox.
Contributor
Author
There was a problem hiding this comment.
Didn't work in my 15.6 Safari for some reason, I'll remove it if it's not needed as soon as we setup our browser list configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/SRCH-78/svelte-improve-repository-revision-picker-ui
Just a package of small fixes in different places (group them in one PR to avoid having a lot of super small PRs before the release. These fixes include
Add Search files quick actions for collapsed file sidebar state
Updates for tabs appearance
Update fuzzy finder appearance (most of the styles that we have in the react version and fixes for Safari)
Test plan