During manual testing for https://github.com/sourcegraph/sourcegraph/pull/62934, I started realizing that I would run into database errors:

failed to deallocate cached statement(s): conn busy

Turns out, pgx.Conn is meant for non-concurrent use. What we really want is a connection pool, with an off-the-shelf offering from pgxpool.

Test plan

Integration tests pass, now with more cases using t.Parallel(). Also ran a quick sanity check by hand:

sg start

for i in {1..10}; do curl --header "Content-Type: application/json" --header 'authorization: bearer $SAMS_TOKEN' --data '{"filters":[{"filter":{"is_archived":false}}]}' \
    http://localhost:6081/enterpriseportal.subscriptions.v1.SubscriptionsService/ListEnterpriseSubscriptionLicenses & ; done

Changelog

• The MSP runtime lib/managedservicesplatform/contract.Contract's ConnectToDatabase(...) has been renamed to GetConnectionPool(...), and now returns a *pgxpool.Pool instead of a *pgx.Conn
• The MSP runtime lib/managedservicesplatform/cloudsql helper library's Connect(...) has been renamed to GetConnectionPool(...), and now returns a *pgxpool.Pool instead of a *pgx.Conn