This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cody PLG: add support for Google Gemini models#62993
Merged
Merged
Conversation
This change adds support for the Google Gemini 1.5 Flash and Pro models in the ModelBadges component and the isAllowedCustomChatModel function. This allows these models to be displayed and used in the Sourcegraph product subscriptions UI and chat functionality.
olafurpg
approved these changes
May 31, 2024
olafurpg
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍🏻
I'm not 100% familiar wit this part of the code. My understanding: this adds Gemini Pro/Flash to the same list of models where we already declare GPT-4o support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for the Google Gemini 1.5 Flash and Pro models in the ModelBadges component and the isAllowedCustomChatModel function. This allows these models to be displayed and used in the Sourcegraph product subscriptions UI and chat functionality.
Test plan
Changelog
In your sg local instant, look for the gemini models in the license page.
Verify you are not seeing the following error when running the curl command listed in https://sourcegraph.slack.com/archives/C05AGQYD528/p1717105626504719?thread_ts=1717011825.198899&cid=C05AGQYD528:
{"error":"model \"google/gemini-1.5-flash-latest\" is not allowed, allowed: []"}