This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Remove external accounts modal feature flag#62983
Merged
pjlast merged 2 commits intoJun 3, 2024
Merged
Conversation
eseliger
approved these changes
May 30, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
I assume there was no additional feedback from the customer who trialed this initially and this is working and good to ship to all?
Contributor
Author
|
@eseliger the one request we still have is to make the modal undismissable, and I don't think that's something we want for everyone so might need some sort of configuration for that part. |
Member
|
Makes sense, we can ship that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62805
#61721 introduced a modal reminding users to connect external accounts. It was put behind a feature flag in case of malfunction. But since then, it seems to work as expected based on customer feedback.
This PR removes the feature flag, and turns the feature on by default, since we think it's an improvement to the user experience over all.
Test plan
Feature flag removed and verified to work by default.
Changelog