Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Svelte: simplify and grow last commit#62978

Merged
camdencheek merged 1 commit into
mainfrom
cc/long-last-commit
May 30, 2024
Merged

Svelte: simplify and grow last commit#62978
camdencheek merged 1 commit into
mainfrom
cc/long-last-commit

Conversation

@camdencheek

@camdencheek camdencheek commented May 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This makes various tweaks and simplifications to the LastCommit component shown on the file page.

  • Uses the Timestamp component
  • Removes a bunch of unnecessary DOM elements and styles in favor of just using flexbox well
  • Removes the max width on the last commit component, allowing it to take up as much space as is available (but leaving a healthy gap from the tabs). This was the primary reason I tackled this PR. Most commits I see are truncated to the "barely useful" level

Test plan

screenshot-2024-05-29_20-39-40.mp4

@cla-bot cla-bot Bot added the cla-signed label May 30, 2024
camdencheek
camdencheek commented May 30, 2024
View reviewed changes
Comment thread client/web-sveltekit/src/lib/Avatar.svelte Outdated

@camdencheek camdencheek May 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avatars, like icons, should never shrink

@camdencheek camdencheek force-pushed the cc/long-last-commit branch from 43cd900 to 714ee05 Compare May 30, 2024 02:32
@camdencheek camdencheek force-pushed the cc/long-last-commit branch from 714ee05 to 0da1e59 Compare May 30, 2024 02:33
@camdencheek camdencheek requested a review from a team May 30, 2024 02:42
fkling
fkling approved these changes May 30, 2024
View reviewed changes

@fkling fkling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been bothering me as well. Great simplification too!

@camdencheek camdencheek merged commit 0e2a668 into main May 30, 2024
@camdencheek camdencheek deleted the cc/long-last-commit branch May 30, 2024 14:17
@taiyab

taiyab commented May 30, 2024

Copy link
Copy Markdown
Contributor

Thanks for this @camdencheek.

Once the new symbol tree goes in, we can consider removing the references tab from that bottom bar, and converting that entire bottom part to be a simple 4/1 split with the last commit + open all history action on the left (and left aligned), and ownership info on the right.

Having a long and right-aligned commit message like that doesn't really work, but we'll have to deal with it for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@fkling fkling fkling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camdencheek @taiyab @fkling